-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tic-tac-toe React prototype #665
feat: add tic-tac-toe React prototype #665
Conversation
Hey @zairahira ! The prototype looks good so far. This will be discussed more in tuesday's meeting, but we are changing what will be shipped by Christmas. As a result, let's push pause on the tic toe game and resume in Q1 of 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test this locally and it is working well on my end.
Most of comments center around exports.
The structure for how we build react projects might change but for now, we should assume that there is just going to be one file for the parent and child components and one export instead of multiple.
@@ -0,0 +1,84 @@ | |||
export const Square = ({ value, onClick }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the current react implementation on learn, I don't know if we are going to be able to export multiple child components into a parent component.
right now, it looks like we just have one index.jsx
file and the parent and child components are all in that file.
So we might need to remove these export keywords for all of the child components.
11. Your `Board` component should render a grid of `Square` components for the 3x3 Tic-Tac-Toe board. | ||
12. You should create and export a `resetGame` function that resets the game state to its initial values when triggered. | ||
13. You should create and export an `App` component that renders the `Board` component. | ||
14. The `App` component should be rendered to the DOM inside a `div` with the class `App`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could remove this because looking at the other react projects, it looks like we are already giving them the boilerplate code in the index.html
Co-authored-by: Jessica Wilkins <[email protected]>
Thank you for sharing the feedback Jessica. I have implemented the following suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small comment but otherwise this is good to go
Checklist:
Update index.md
)Closes #642